serokell / coffer

Multi-backend password store with multiple frontends
4 stars 2 forks source link

[#93] Web API + web API test #37

Closed Heimdell closed 2 years ago

Heimdell commented 2 years ago

Description

Web API for Coffer + js mocha tests.

Related issue(s)

Fixe3 #93

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Stylistic guide (mandatory)

dcastro commented 2 years ago

@DK318: Can you please take over this PR?

Here's the plan:

  1. Rebase it on main and fix any conflicts
  2. Reorganize commits into atomic changes. Right now there's a lot of commits that merely fix or amend previous commits (e.g. "Fixes after rebase", "Add /find test"). I think it would make sense to have these commits (just a suggestion):
    • Implement Web API (Server.hs and API.hs)
    • Add an executable component for the Web API (edits package.yaml, moves the CLI's cli/Main.hs, adds a new server/Main.hs).
    • Add mocha tests for the Web API
  3. Add Problem/Solution to each commit, tag each commit with the issue number (I created an issue here: #93)
  4. Get the pipeline green
  5. Address the comments you and I left on this PR

If any concerns arise, please open a new issue and we'll fix it after #37 is merged. I already opened a few and tagged them with the web-api label, see: https://github.com/serokell/coffer/labels/web-api . This will allow the team to work on them in parallel.

Unless it's a critical issue, in which case we should talk about it and possibly solve it here in this PR.

DK318 commented 2 years ago

OK. No problem :smiley:

sancho20021 commented 2 years ago

Some new conflicts appeared, as there were recent pushes in main branch :( Would you please resolve them?

DK318 commented 2 years ago

@sancho20021 I'll resolve them when I start merging