Closed DK318 closed 2 years ago
I'm starting to think Entry
should have a QualifiedPath EntryPath
instead of an EntryPath
.
But this is outside the scope of this PR. I'll have a deeper look at this later and re-valuate where and how we should use QualifiedPath
.
LGTM :+1:
Regarding the code itself, LGTM. Architecturally:
QualifiedPath
is a weird a name, especially when specialized as QualifiedPath Entry
. Imo we should rename it and maaybe add a class constraint just so the types are a bit tighter and represent more what we meantEntry
should take on a QualifiedPath EntryPath
or such field. Two entries from two backends should be equivalent, once an entry is read, its not bound to any one backend, it just exists. Adding more data on top of it with QualifiedPath
or similar is imo the right way to go
Description
Problem
coffer
messages don't show backend name in paths. Sometimes we need it. For e.g.It looks very odd.
Solution
Supported qualified paths in
coffer
messages. Now example above would print nextRelated issue(s)
Related changes (conditional)
Tests
Documentation
Public contracts
Stylistic guide (mandatory)