[#39] String interpolation in `coffer` output messages - Githubissues

serokell / coffer

Multi-backend password store with multiple frontends

4 stars 2 forks source link

[#39] String interpolation in `coffer` output messages #63

Closed DK318 closed 2 years ago

DK318 commented 2 years ago

Description

Problem

At this moment constructing some messages in Main.hs looks very convoluted (e.g. message in set-field command).

Solution

Used nyan-interpolation package in Main.hs.

Related issue(s)

Fixes #39
Related changes (conditional)
- Tests
  - [ ] If I added new functionality, I added tests covering it.
  - [ ] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
- Documentation
  - [x] I checked whether I should update the docs and did so if necessary:
  - README
  - Haddock
- Public contracts
  - [x] Any modifications of public contracts comply with the Evolution of Public Contracts policy.
  - [x] I added an entry to the changelog if my changes are visible to the users and
  - [x] provided a migration guide for breaking changes if possible
Stylistic guide (mandatory)
- [x] My commits comply with the policy used in Serokell.
- [x] My code complies with the style guide.

DK318 commented 2 years ago

Oh, this PR is really outdated. Still waiting for a review :smile:

dcastro commented 2 years ago

Oh, this PR is really outdated. Still waiting for a review :smile:

Looks like you have 2 reviews now, I really only had that 1 small comment ^^

DK318 commented 2 years ago

Oh. This Review required got me distracted