Closed DK318 closed 2 years ago
Id move VaultError
into the backend folder, but aside from that LGTM
Id move VaultError into the backend folder, but aside from that LGTM
Agreed. More specifically, the Backend/Vault
folder.
Either to its own file or to the Backend.Vault.Kv
module, whichever you prefer.
Description
Problem
There are 2 problems here:
Backend.Vault.Kv
module, we're constructingOtherError
with user-facing error messages as strings.CofferError
is meant to be backend-agnostic, but it assumes that all backends will (possibly) throw aServantError
. However, thepass
backend, for example, does not use servant.Solution
CofferError
backend-agnostic.Related issue(s)
Fixed #
:white_check_mark: Checklist for your Pull Request
Related changes (conditional)
Tests
Documentation
Stylistic guide (mandatory)