serokell / coffer

Multi-backend password store with multiple frontends
4 stars 2 forks source link

[#72] Backend-agnostic `CofferError` GADT #73

Closed DK318 closed 2 years ago

DK318 commented 2 years ago

Description

Problem

There are 2 problems here:

Solution

  1. Used ADTs + Buildable to model errors.
  2. Made CofferError backend-agnostic.
  3. Created backend-specific error type class.

Related issue(s)

Fixed #

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Stylistic guide (mandatory)

MagicRB commented 2 years ago

Id move VaultError into the backend folder, but aside from that LGTM

dcastro commented 2 years ago

Id move VaultError into the backend folder, but aside from that LGTM

Agreed. More specifically, the Backend/Vault folder.

Either to its own file or to the Backend.Vault.Kv module, whichever you prefer.