[#22] Copy with equal paths behavior fix

sancho20021 commented 2 years ago

Description

Problem

Currently copying entry / directory to itself is allowed in force mode.

This copying is very unnecessary, we can't see such behavior in standard Unix cp command. The same applies to renaming entries to it's current name.

Solution

Check qualified paths for equality before copying.

Related issue(s)

Fixed #22

:white_check_mark: Checklist for your Pull Request

Related changes (conditional)

Tests
- [x] If I added new functionality, I added tests covering it.
- [x] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.
Documentation
- [x] I checked whether I should update the docs and did so if necessary:
- README
- Haddock

Stylistic guide (mandatory)

[x] My commits comply with the policy used in Serokell.
[x] My code complies with the style guide.

dcastro commented 2 years ago

Please turn on trimming trailing whitespace in your editor.

This. I think you're using vscode, right? If so, you can add this to your preferences:

    "files.insertFinalNewline": true,
    "files.trimFinalNewlines": true,
    "files.trimTrailingWhitespace": true,

sancho20021 commented 2 years ago

Yes, thanks! Didn't have that in my configuration

dcastro commented 2 years ago

There's an issue with the xrefcheck step in the pipeline, @DK318 is working on it (see #79).

Once his PR is merged, please rebase your branch on top of main, and the pipeline for your PR should start passing.

serokell / coffer