When deploy fails, some child processes seem to persist beyond the parent

serokell / deploy-rs

A simple multi-profile Nix-flake deploy tool.

Other

1.39k stars 101 forks source link

When deploy fails, some child processes seem to persist beyond the parent #222

Open wmertens opened 1 year ago

wmertens commented 1 year ago

Most obvious when I'm doing --auto-rollback false. The deploy fails and returns to prompt, and after that I get the message 👀 ❌ [wait] [ERROR] Error waiting for activation: Timeout elapsed for confirmation.

wmertens commented 1 year ago

I have further information on this: The process is activate-rs.

It might be because of my ssh configuration that uses a persistent connection with an auto master?

In any case, I'd expect that when I press Ctrl-C, the activate-rs SSH command also gets killed, and that when the deploy fails, the activate-rs is awaited.

henrikvtcodes commented 2 months ago

I also have experienced this. Sometimes even when a deploy succeeds a message will appear.

IMO the behavior should be to only exit once all processes have ended.