search

serokell / deploy-rs

A simple multi-profile Nix-flake deploy tool.
Other
1.33k stars 101 forks source link

[Chore] Make activation wait timeout configurable #240

Closed rvem closed 11 months ago

rvem commented 11 months ago

Problem: Currently profile activation waiting timeout is hardcoded to 240 seconds, see https://github.com/serokell/deploy-rs/pull/48. In some cases, this timeout can be exceeded (e.g. activation performs a heavy DB migration and waits for it to finish before considering the profile activation succesful).

Solution: Make this timeout configurable via 'activationTimeout' deploy attribute or corresponding '--activation-timeout' CLI option. For the sake of backward compatibility, the 'wait' subcommand new '--activation-timeout' option is made optional and defaults to 240 seconds if it wasn't provided.

SufyanDahalan commented 9 months ago

Hey @PhilTaken Can you document it? I stumbled upon it by mistake and I could only find it in the code, not in any docs or examples. Thanks!

rvem commented 9 months ago

Hey, @SufyanDahalan. Thanks for catching the lack of documentation, we'll update it