serokell / deploy-rs

A simple multi-profile Nix-flake deploy tool.
Other
1.22k stars 100 forks source link

Can't disable auto rollback #241

Closed StillerHarpo closed 8 months ago

StillerHarpo commented 8 months ago

I have the following config

        deck = {
          hostname = (import ./variables.nix).nixosDeckIP;
          profiles.system = {
            user = "root";
            sshUser = "root";
            remoteBuild = true;
            autoRollback = false;
            magicRollback = false;
            path = inputs.deploy-rs.lib.x86_64-linux.activate.nixos
              self.nixosConfigurations.nixosDeck;
          };
        };

Expected behaivor

deploy-rs doesn't rollback on failore

Actual behaivor

⭐ ❌ [activate] [ERROR] The activation script resulted in a bad exit code: Some(4)
🚀 ❌ [deploy] [ERROR] Activating over SSH resulted in a bad exit code: Some(1)
🚀 ℹī¸ [deploy] [INFO] Revoking previous deploys
🚀 ❌ [deploy] [ERROR] Deployment failed, rolled back to previous generation
notgne2 commented 8 months ago

Does the rollback actually take place? iirc there's issues where the logging/output just gives completely uninformative nonsense sometimes, often claiming to roll back or revoke when it isn't doing anything.