serokell / haskell-crypto

Haskell cryptography done right
https://hackage.haskell.org/package/crypto-sodium
15 stars 6 forks source link

Make parseEscape errors more informative #37

Open lierdakil opened 2 years ago

lierdakil commented 2 years ago

Allow partial parses in 'parseEscapes', but use a greedy parser. Show the character escape that failed to parse and input position in the error message.

lierdakil commented 2 years ago

The change looks good to me, but can you please add tests that exercise all the error conditions?

I've added a couple tests.