search

serokell / haskell-with-utf8

Get your IO right on the first try
https://serokell.io/blog/haskell-with-utf8
52 stars 3 forks source link

Make it build with ghc-9.10 #32

Closed erikd closed 3 months ago

erikd commented 3 months ago

There are numerous warnings compiling the test suite, but it compiled and all the tests passed.

I am a Hackage Trustee and can do this base bump if you would like me to,

gromakovsky commented 3 months ago

@erikd thanks. I've just tried running cabal test -w ghc-9.10.1 with these changes and it succeeded without warnings. I'm curious about 2 things:

  1. Which warnings did you get and how?
  2. According to https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/libraries/version-history, ghc-9.10.1 should imply filepath-1.5.2.0. And we have filepath >=1.0 && <1.5. Nevertheless, somehow it compiles. Do you know why? I wonder why it's not necessary to bump the filepath constraint 🤔
erikd commented 3 months ago

@gromakovsky Yes, you are right. All the warnings are in dependencies rather than in your test suite.

And yes, filepath could do with a version bump:

> cabal outdated
Outdated dependencies:
filepath >=1.0 && <1.5 (latest: 1.5.3.0)

I have updated the PR to include that.