serokell / log-warper

Logging library to provide more convenient, extremely configurable but simple monadic interface with pretty output
MIT License
19 stars 11 forks source link

Failing to build on stackage nightly #25

Closed cdornan closed 6 years ago

cdornan commented 7 years ago

We are seeing errors in building for stackage nightly with the following error:

[11 of 17] Compiling System.Wlog.Logger ( src/System/Wlog/Logger.hs, dist/build/System/Wlog/Logger.o )

src/System/Wlog/Logger.hs:324:27: warning: [-Wdeprecations]
    In the use of <E2><80><98>fold<E2><80><99> (imported from Data.Map):
    Deprecated: "As of version 0.5, replaced by 'foldr'."
    |
324 |         let allHandlers = M.fold (\l r -> concat [r, view lHandlers l]) [] liTree
    |                           ^^^^^^
[12 of 17] Compiling System.Wlog.CanLog ( src/System/Wlog/CanLog.hs, dist/build/System/Wlog/CanLog.o )
[13 of 17] Compiling System.Wlog.Wrapper ( src/System/Wlog/Wrapper.hs, dist/build/System/Wlog/Wrapper.o )
[14 of 17] Compiling System.Wlog.LoggerConfig ( src/System/Wlog/LoggerConfig.hs, dist/build/System/Wlog/LoggerConfig.o )

src/System/Wlog/LoggerConfig.hs:82:54: error:
    Ambiguous occurrence <E2><80><98>notElem<E2><80><99>
    It could refer to either <E2><80><98>Universum.notElem<E2><80><99>,
                             imported from <E2><80><98>Universum<E2><80><99> at src/System/Wlog/LoggerConfig.hs:56:1-26
                             (and originally defined in <E2><80><98>Containers<E2><80><99>)
                          or <E2><80><98>Data.List.notElem<E2><80><99>,
                             imported from <E2><80><98>Data.List<E2><80><99> at src/System/Wlog/LoggerConfig.hs:62:42-48
                             (and originally defined in <E2><80><98>Data.Foldable<E2><80><99>)
   |
82 | filterObject excluded = HM.filterWithKey $ \k _ -> k `notElem` excluded
   |                                                      ^^^^^^^^^

We have taken log-warper out of nightly. Once the issue has been fixed would you raise either a stackage PR or issue so we can get it restored to stackage.

chshersh commented 7 years ago

@cdornan Thanks a lot for reporting this! I really appreciate your effort. Sorry for such building problems. This is now fixed both in master and 1.3.2 version on Hackage. It builds now with nightly-2017-10-13 resolver.

chshersh commented 7 years ago

He, @cdornan! Does the fix work for you? I don't see log-warper in stackage nightly currently... Let me know if I need to fix something else, please :)

chshersh commented 6 years ago

Outdated. Newer version is already in stackage nightly. And has another issue...