search

serokell / log-warper

Logging library to provide more convenient, extremely configurable but simple monadic interface with pretty output
MIT License
19 stars 11 forks source link

[LW-28] Remove duplicate printing of ERROR #44

Closed vrom911 closed 6 years ago

vrom911 commented 6 years ago

Resolves #45

chshersh commented 6 years ago

@vrom911 It's getting better! Several things to refactor to improve quality of log-warper:

  1. Could you please remove releaseAllHandlers from Terminal module and change type of removeAllHandlers from IO to MonadIO m => m?
  2. Could you please move setSeverity and setSeverity functions from this module to Logger modules?
  3. Rename Handler module to LogHandler.
  4. Lift all functions inside Logger module to MonadIO please (and remove redundant liftIO from other places). And I think you can remove trapLogging function, it's not used anywhere.
  5. Rename Logger module to IOLogger.
  6. debugM errorM infoM noticeM etc. functions are not needed anymore.