search

serokell / o-clock

:hourglass: Type-safe time units in Haskell
Mozilla Public License 2.0
49 stars 6 forks source link

Decide (and fix) what to do with 0 time passed to 'seriesF' #45

Closed chshersh closed 6 years ago

chshersh commented 6 years ago

I think that if 0 time is passed to seriesF formatter we want to use 0smth. So the question is what you would like to see in case you call:

seriesF @'[Hour, Second] (minute 0)
  1. 0h
  2. 0m
  3. 0s
chshersh commented 6 years ago

Personally I think that 0h should be outputted in that case. Definitely not 0m because it clearly conflicts with user's intent. I don't see difference between 0h and 0s. But it's easier to implement 0h :slightly_smiling_face: