search

serokell / tezos-packaging

Various forms of Tezos software distribution for Linux and macOS.
MIT License
60 stars 21 forks source link

Path to v20.1-2 release still points to v20.1-1 directory. #813

Closed mturadek-ledger closed 3 months ago

mturadek-ledger commented 3 months ago

Clarification and motivation

I use automation for building new Docker images:

# find the latest version
curl -sX GET "https://api.github.com/repos/serokell/tezos-packaging/releases/latest" | jq --raw-output '.tag_name'
v20.1-2

# download the version
curl --fsSL https://github.com/serokell/tezos-packaging/releases/download/v20.1-2/binaries-octez-v20.1-2.tar.gz -o /app/tezos/binaries-octez-${VERSION}.tar.gz

curl: (22) The requested URL returned error: 404

Unfortunately, version 20.1-2 is still downloaded as version 20.1-1, so the pattern needs to be fixed.

Acceptance criteria

Can you fix the binaries' naming and adequately expose them to the directory (v20.1-2) reflecting the tag (v20.1-2)?

DMozhevitin commented 3 months ago

Hi! Sorry for the inconvenience, this issue was resolved in the latest release. The issue was that we didn't bump the release number in one of our scripts.

Is it ok to you to use the latest release with correct binaries names, or you want us to fix them from v20.1-2?

mturadek-ledger commented 3 months ago

Hi!

Thank you very much for getting back to me so quickly.

There are no other steps needed.

Many thanks!

DMozhevitin commented 3 months ago

No problem 😄 , closing the issue then.