serokell / tzbot

Timezone bot for Slack
Mozilla Public License 2.0
7 stars 2 forks source link

Consider detecting when user claims the bot's to be working incorrectly #19

Closed Martoon-00 closed 1 year ago

Martoon-00 commented 1 year ago

Clarification and motivation

Correctly parsing the time references from the user's messages is a very difficult task that may require many polishing iterations.

Thus I suggest leaving an easy way for a user to say: "Time bot didn't react to my message" or "Time bot converted the time incorrectly".

If this initiative makes sense, we should do the following:

Acceptance criteria

YuriRomanowski commented 1 year ago

I think that we should try to record only really wrongly processed messages, because it will be rather difficult to filter them out if they are mixed with correctly processed ones. What can be reasonable to consider:

As for how to record the feedback left, do you propose to write directly to the serokell owned channel? I think it's reasonable to use while our bot is just our internal tool, later we will have to eliminate this feature I think. But we can just log these messages to a simple file, separately from other logs, and later we can process these files.

Does it make sense?

Martoon-00 commented 1 year ago

I agree that we better report only bad messages.

/report functionality with ability to specify the exact reason sounds awesome, much better than what I proposed with automatic detection.

From time to time, randomly, add some information to the time-translating messages, or just post separate messages to channels several times a day.

Which information?

As for how to record the feedback left, do you propose to write directly to the serokell owned channel?

Yes. And yep, that's probably only useful for us.

I worry that in case of files - someone will have to go and check them periodically, and that would increase the reaction time.

Probably after #33 we should consider this point again. If we eventually add some monitoring system, then we can easily tune up Logs -> Monitoring -> Slack / E-mail / anything else.