search

serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 28 forks source link

[#98] Add universum specific hlint.yaml #146

Closed vrom911 closed 6 years ago

vrom911 commented 6 years ago

I have already checked it on one private repositories and it seems to be working Resolves #98

vrom911 commented 6 years ago

@ChShersh , this is WIP, more work should be done still. I haven't added any tests and reexport part is not completely finished, need to check some more modules. Sorry, I will finish that later in the evening. Also few comments to consider:

I wonder, will it work to replace putStrLn (s :: Text) with putTextLn

I checked this doesn't work this way, unfortunately..

I want to suggest bug over error but can't think of good way to do this...

This is also not implemented.

chshersh commented 6 years ago

I checked this doesn't work this way, unfortunately..

Agree, that's unfortunate... Would love to see type-directed linter some day.

This is also not implemented.

Well, it's not easy to implement. Because we want all transformations be valid. I don't know how to suggest bug over error. So let's not do it for now. Especially when we will have a lot of warnings in new project after applying universum-specific HLint (if we have error ==> bug rule).

vrom911 commented 6 years ago

@ChShersh while testing hlint on the project I found out few issues. I would like you to be aware of that behavior..