search

serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 28 forks source link

Some fixes for 1.3.0 #184

Closed rockbmb closed 6 years ago

rockbmb commented 6 years ago

Fixes #167, fixes #174.

rockbmb commented 6 years ago

@gromakovsky Things are deprecated instead of removed. Exceptions are mask_ (reexport, cannot deprecate it unless it is redefined locally and then export this local definition, do we want to do this?) and type-operators operators, which were redefined locally and reexported per #174.

gromakovsky commented 6 years ago

reexport, cannot deprecate it unless it is redefined locally and then export this local definition, do we want to do this?

Hm, that's a good question actually. Redefining locally looks a bit messy, but seems to solve the problem and apparently doesn't have big downsides. So I'd do it this way. Btw, I googled a little bit and found a GHC ticket proposing a good solution for this problem: https://ghc.haskell.org/trac/ghc/ticket/4879 Unfortunately, it's still not implemented, even though 8 years passed.

gromakovsky commented 6 years ago

fixes #177, fixes #178, fixes #179, fixes #180 and fixes #181.

These five issues shouldn't be closed by this PR, because deprecation is only the first step. They should be closed after actual deletion which will happen later.

rockbmb commented 6 years ago

@gromakovsky things should be acceptable now.

rockbmb commented 6 years ago

@gromakovsky fixed 👍

rockbmb commented 6 years ago

@gromakovsky not sure what's up with GitHub's PR commit history, mine is different than what is shown here. I do not have 2 repeated "Update CHANGES.md" commits. Anyway, fixed. Again 😄

@volhovm please помогите review/approve.

gromakovsky commented 6 years ago

I propose to wait until the end of this week and then merge if nothing happens.

gromakovsky commented 6 years ago

https://i.imgur.com/dmtIboa.png

I somewhat dislike that there is an empty line before Migration guide: in one place and there is no empty lines in other places. I think it should be the same for each change. Version with empty line looks better to me.

rockbmb commented 6 years ago

@gromakovsky Hmm, I agree. I'll fix it quickly now.

rockbmb commented 6 years ago

@gromakovsky good to go?