search

serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 28 forks source link

Enable -Werror and few more warnings #185

Closed gromakovsky closed 4 years ago

gromakovsky commented 6 years ago

I think we shouldn't permit warnings, but apparently we do. Also I'd enable -Wcompat -Wincomplete-uni-patterns -Wincomplete-record-updates -Wredundant-constraints. You can read about them here. They seem to be harmless and helpful.

dniku commented 6 years ago

We can also use the same set of warnings as was recently introduced in Ariadne.

gromakovsky commented 6 years ago

https://github.com/serokell/ariadne/blob/624b379e508fcc926eca3dc8cf4c2af1d02a7147/hpack/definitions.yaml#L61