search

serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 28 forks source link

Fixes for 1.4.0 #193

Closed rockbmb closed 6 years ago

rockbmb commented 6 years ago

Closes #177, closes #178, closes #179, closes #180, closes #181, and closes #192.

rockbmb commented 6 years ago

To be reviewed in September 2018.

rockbmb commented 6 years ago

@gromakovsky September has come 😄

rockbmb commented 6 years ago

@gromakovsky fixed 👍. As for reviews, @volhovm взгляни, пожалуйста.

rockbmb commented 6 years ago

@Pastafarianist Mind taking a look as well? Won't take too long, and it'll help move universum forward.

gromakovsky commented 6 years ago

AFAIK, @volhovm is moving to Paris, that's why he's inactive these days. He was going to review current PRs this week though.

rockbmb commented 6 years ago

@volhovm The only occurrences of the relevant functions are in CHANGES.md, either to inform they were added in a previous version, or to inform they are going to be removed in 1.4.0.

gromakovsky commented 6 years ago

@rockbmb please rebase on latest master and let's merge this PR.

rockbmb commented 6 years ago

@gromakovsky done.