Closed JustusAdam closed 5 years ago
Also, this is a slightly breaking change, because more general version of withFile
can break type inference, but I think that's very unlikely, so I'd treat it as a "feature" instead :)
One, kind of general, question I have is, should I reword the commits? I only just read that, if there's an issue you prefer to prefix commits with issue numbers. If you like, I can reword the commit messages to follow this policy.
Looks nice
So I read the heading of #186 and thought "hey, they should have
withFile
". Only after I started to implement it did I realize that discussion was already happening.So I sort of accidentally already did the implementation.
This version currently exports
withFile
andopenFile
andhClose
. And simply advises against usingopenFile
andhClose
in the documentation. Once we've settled the discussion of what should be exported this can be adjusted as needed.