Closed JustusAdam closed 5 years ago
Actually while we're here, why does die
use String
? Shouldn't it use Print a
instead, or at the very least Text
?
Please update changelog here as well and rebase on latest master
.
And now there are some unrelated commits in this PR :/
Oh shoot ... It seems I messed up my branches :see_no_evil:
There we are. Some cherry picking did the trick.
For some reason your lifted version of
die
ism ()
, when it could bem a
.I skimmed through the issues and
CHANGES.md
but I could not find a reference as to why this was done, so I'm proposing to change it to a more general type. This is also the same type signature as theexitWith
family as wenn as thedie
version inbase
.Furthermore this, more general type signature is actually useful, particularly when handling erroneous user data.