search

serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 26 forks source link

Generalize the type of `die` #201

Closed JustusAdam closed 5 years ago

JustusAdam commented 5 years ago

For some reason your lifted version of die is m (), when it could be m a.

I skimmed through the issues and CHANGES.md but I could not find a reference as to why this was done, so I'm proposing to change it to a more general type. This is also the same type signature as the exitWith family as wenn as the die version in base.

Furthermore this, more general type signature is actually useful, particularly when handling erroneous user data.

JustusAdam commented 5 years ago

Actually while we're here, why does die use String? Shouldn't it use Print a instead, or at the very least Text?

gromakovsky commented 5 years ago

Please update changelog here as well and rebase on latest master.

gromakovsky commented 5 years ago

And now there are some unrelated commits in this PR :/

JustusAdam commented 5 years ago

Oh shoot ... It seems I messed up my branches :see_no_evil:

JustusAdam commented 5 years ago

There we are. Some cherry picking did the trick.