Make `error` print callstack of its call site rather than its definition

[Martoon-00]

Description

As we know, our error is funny:

*** Exception: 123
CallStack (from HasCallStack):
  error, called at /home/martoon/serokell/universum/src/Universum/Debug.hs:62:11 in main:Universum.Debug
  error, called at <interactive>:1:1 in interactive:Ghci1

I hope I fixed it to work as expected:

• Called from ghci:

  λ> error "123"
  *** Exception: 123
  CallStack (from HasCallStack):
  error, called at <interactive>:2:1 in interactive:Ghci1

• Called from code:

  λ> meme
  *** Exception: What meme?
  CallStack (from HasCallStack):
  error, called at /home/martoon/serokell/universum/src/Universum/Debug.hs:109:7 in main:Universum.Debug

Related issues(s)

No corresponding issue exist.

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

• [x] I made sure my PR addresses a single concern, or multiple concerns which are inextricably linked. Otherwise I should open multiple PR's.
• [x] If your PR fixes/relates to an open issue then the description should reference this issue. See also auto linking on github.

Related changes (conditional)

• Tests

  • [x] If I added new functionality, I added tests covering it.
  • [x] If I fixed a bug, I added a regression test to prevent the bug from silently reappearing again.

• Documentation

  I checked whether I should update the docs and did so if necessary:

  • [x] README
  • [x] Haddock

• Record your changes

  • [x] I added an entry to the changelog if my changes are visible to the users and
  • [x] provided a migration guide for breaking changes if possible

Stylistic guide (mandatory)

• [x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.

  Example: [#42] Short commit description

  If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.

[gromakovsky]

I think it makes sense to add a test where you call error, then catch ErrorCall and check that the second String in ErrorCallWithLocation contains expected number of newline characters (AFAIU, 2, if the string passed to error doesn't have them).

[Martoon-00]

It seems to me, that examining the number of newlines would be more fragile than useful. Our error implementation will hardly ever change since now (unless GHC improves error again). On the other hand, if GHC changes the text of the error, that test case would need to catch up. I'm not completely sure though, @gromakovsky if you disagree with this point I'll add the test.

There seems to be no way to extract CallStack from the exception thrown by the error unfortunately.

[Martoon-00]

Thanks, done.