serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 26 forks source link

Fix documentation in Universum.Lifted.File to mention correct module #215

Closed serhiip closed 5 years ago

serhiip commented 5 years ago

Description

There is a typo in referenced module names - there is no file related functions in Data.Text (correct module is Data.Text.IO). This PR fixes the issue.

Issue could be observed here http://hackage.haskell.org/package/universum-1.5.0/docs/Universum-Lifted-File.html

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

gromakovsky commented 5 years ago

LGTM, thanks. We should merge #216 first to make CI pass here, then you'll have to rebase on latest master.

serhiip commented 5 years ago

As #216 is merged I've rebased this one

gromakovsky commented 5 years ago

Can you please make history linear here?

serhiip commented 5 years ago

Rebased everything onto master

gromakovsky commented 5 years ago

Oh, and now the only remaining obstacle is this:

The base branch requires all commits to be signed.

serhiip commented 5 years ago

Oh c'mon

gromakovsky commented 5 years ago

Thanks for your patience.