serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 26 forks source link

Add xrefcheck #224

Closed gromakovsky closed 4 years ago

gromakovsky commented 4 years ago

Description

Use the xrefcheck tool to ensure that cross-references are valid.

Related issues(s)

None

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

gromakovsky commented 4 years ago

Ah, I guess I should make this check optional. I am considering switching CI to GitHub actions, so maybe I'll do that first.

Martoon-00 commented 4 years ago

Mda, 6 jobs each resolving all refs to issues located in CHANGES.md. 429 guaranteed, need to do something with this soon.

Probably it's worth enabling retry: https://docs.travis-ci.com/user/common-build-problems/#travis_retry

gromakovsky commented 4 years ago

Doing it in 6 jobs definitely does not make sense. I'd like to try GitHub actions first before doing it properly.

Martoon-00 commented 4 years ago

Ah right, I see

gromakovsky commented 4 years ago

I might end up doing xrefcheck-action and using it here before considering this PR done.

gromakovsky commented 4 years ago

Alright, I think all issues are resolved and it works pretty nicely now.

gromakovsky commented 4 years ago

I've also bumped the version to 1.7.0 because I want to make a new release and don't want to make another PR for that.

Martoon-00 commented 4 years ago

Since you are going to make a release, may I quickly add one small PR? Wanna have it soon

Martoon-00 commented 4 years ago

I was wrong, that issue is already resolved. Let's make a release :)

gromakovsky commented 4 years ago

Great!