Closed gromakovsky closed 4 years ago
Ah, I guess I should make this check optional. I am considering switching CI to GitHub actions, so maybe I'll do that first.
Mda, 6 jobs each resolving all refs to issues located in CHANGES.md
. 429 guaranteed, need to do something with this soon.
Probably it's worth enabling retry: https://docs.travis-ci.com/user/common-build-problems/#travis_retry
Doing it in 6 jobs definitely does not make sense. I'd like to try GitHub actions first before doing it properly.
Ah right, I see
I might end up doing xrefcheck-action
and using it here before considering this PR done.
Alright, I think all issues are resolved and it works pretty nicely now.
I've also bumped the version to 1.7.0 because I want to make a new release and don't want to make another PR for that.
Since you are going to make a release, may I quickly add one small PR? Wanna have it soon
I was wrong, that issue is already resolved. Let's make a release :)
Great!
Description
Use the xrefcheck tool to ensure that cross-references are valid.
Related issues(s)
None
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.