serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 26 forks source link

1.5.0 tests are broken #225

Closed tim2CF closed 4 years ago

tim2CF commented 4 years ago

nixpkgs 19.09-beta ghc 8.6.5

Preprocessing test suite 'universum-test' for universum-1.5.0..
Building test suite 'universum-test' for universum-1.5.0..
[1 of 2] Compiling Test.Universum.Property ( test/Test/Universum/Property.hs, dist/build/universum-test/universum-test-tmp/Test/Universum/Property.o )

test/Test/Universum/Property.hs:34:10: error:
    • Couldn't match type ‘Hedgehog.Internal.Gen.GenBase m’
                     with ‘Identity’
        arising from a use of ‘Gen.unicode’
    • In a stmt of a 'do' block: a <- Gen.unicode
      In the expression:
        do a <- Gen.unicode
           if U.elem a ['\65534', ....] then unicode' else return a
      In an equation for ‘unicode'’:
          unicode'
            = do a <- Gen.unicode
                 if U.elem a [...] then unicode' else return a
    • Relevant bindings include
        unicode' :: m Char (bound at test/Test/Universum/Property.hs:33:1)
   |
34 |     a <- Gen.unicode
   |          ^^^^^^^^^^^

builder for '/nix/store/ca9804yxci12giw7k22mh3q6j4lz4mc3-universum-1.5.0.drv' failed with exit code 1
gromakovsky commented 4 years ago

Is there any particular reason why you are using 1.5.0? It should be fixed in 1c2ff59df54de0c7ca4abb2e9699159b3b0fae83 which is available in 1.6.0 and 1.6.1.

tim2CF commented 4 years ago

I'm using it just because it was in my version of nixpkgs. I'll try out overlay to 1.6.1, thanks

tim2CF commented 4 years ago

well, it not worked, because of different versions of dependencies, but I think this bug is only test-related and code itself is good? I can just apply dontCheck nix helper to omit tests in 1.5.0

gromakovsky commented 4 years ago

Yes, it's only test-related, I think you are trying to compile tests with hedgehog revision ≥ 1.0.0 and they don't compile due to a change in hedgehog.

tim2CF commented 4 years ago

I'll just use 1.5.0 without tests then, thanks!