Closed gpevnev closed 4 years ago
@gromakovsky should I add it as a new minor version (1.7.1
for example)
If I understand PVP correctly, yes. Typically we write Unreleased
in the changelog and replace it with the actual version when a new release is ready to be made, but in this case I suppose we can release 1.7.1 right after merging this PR.
Description
Problem: Currently to lift a value
ma :: Maybe a
intoMaybeT m a
you need to writeMaybeT (pure ma)
, which is bloating code with unnecessary boilerplate. Same idea applies forEither e a
andExceptT e m a
. `Proposed solution: Add functions
hoistMaybe :: Applicative m => Maybe a -> MaybeT m a
andhoistEither :: Applicative m => Either e a -> ExceptT e m a
Related issues
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.