Closed Martoon-00 closed 3 years ago
I am not sure why CI failed, but I see the following link in logs: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
I would try to update setup-haskell
action first. Just add .4
here. It's a brainless way to fix it, maybe it will work. If it doesn't, we'll investigate further.
P. S. Also I think usually we don't merge the target branch into the PR branch in such cases :wink:
Kaef, it helped
Description
Motivation:
some
always returns a non-empty list, and it seems sane to reflect that in types.I do not replace the original
some
because we cannot insert newAlternative
typeclass intoFunctor - Applicative - Monad
chain. And hiding the originalsome
, as I think, isn't worth the potential confusion (when implementing Alternative instance and when just usingsome
I would need differentsome
s).Related issues(s)
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.