serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 26 forks source link

Add `someNE` #233

Closed Martoon-00 closed 3 years ago

Martoon-00 commented 4 years ago

Description

Motivation: some always returns a non-empty list, and it seems sane to reflect that in types.

I do not replace the original some because we cannot insert new Alternative typeclass into Functor - Applicative - Monad chain. And hiding the original some, as I think, isn't worth the potential confusion (when implementing Alternative instance and when just using some I would need different somes).

Related issues(s)

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

gromakovsky commented 3 years ago

I am not sure why CI failed, but I see the following link in logs: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

I would try to update setup-haskell action first. Just add .4 here. It's a brainless way to fix it, maybe it will work. If it doesn't, we'll investigate further.

P. S. Also I think usually we don't merge the target branch into the PR branch in such cases :wink:

Martoon-00 commented 3 years ago

Kaef, it helped