Closed NelosG closed 2 years ago
Hi @NelosG! Thank you for your contribution and apologies for the late reply.
After some debate, the team has decided to delete the note
function (see https://github.com/serokell/universum/issues/176#issuecomment-1084592389), so I'm closing this PR.
@NelosG feel free to make the change that removes note
and re-open this PR (updating it accordingly) or open a new one.
Description
Problem:
note
function has too general name. It's not clear from its name what it does. Solution: Renamednote
function tovalidateJust
.Related issues(s)
note
function tovalidateJust
.✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.