serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
174 stars 26 forks source link

Rename "note" function #251

Closed NelosG closed 2 years ago

NelosG commented 2 years ago

Description

Problem: note function has too general name. It's not clear from its name what it does. Solution: Renamed note function to validateJust.

Related issues(s)

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

dcastro commented 2 years ago

Hi @NelosG! Thank you for your contribution and apologies for the late reply.

After some debate, the team has decided to delete the note function (see https://github.com/serokell/universum/issues/176#issuecomment-1084592389), so I'm closing this PR.

gromakovsky commented 2 years ago

@NelosG feel free to make the change that removes note and re-open this PR (updating it accordingly) or open a new one.