serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
174 stars 26 forks source link

[#265] Make SuperComposition less brittle #267

Open treeowl opened 2 years ago

treeowl commented 2 years ago

Description

Related issues(s)

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

treeowl commented 2 years ago

Is a migration guide required, or is the changelog entry sufficient here? If one is required, where does it go?

treeowl commented 2 years ago

I don't know how to write a regression test for #265; it's both compile-time and subtle. Is that required for this?

treeowl commented 2 years ago

Argh! I think there might be a coherence issue that needs to be resolved. Trying to get inference both ways may be fundamentally wrong.