serokell / universum

:milky_way: Prelude written in @Serokell
MIT License
176 stars 26 forks source link

[#270] Add compatibility with tasty-hedgehog 1.2.0.0 #271

Closed dcastro closed 2 years ago

dcastro commented 2 years ago

Description

Problem: In order to be compliant with the stackage nightly, the test suite needs to buildable with tasty-hedgehog 1.2.0.0. At the moment, we have a constraint on tasty-hedgehog < 1.2.0.0 because that version deprecates the testProperty function (and encourages using testPropertyNamed instead), which we're still using.

Solution: we don't actually need to use either testProperty or testPropertyNamed, we can just use tasty-discover to collect all tests.

Related issues(s)

Fixed #270

✓ Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

gromakovsky commented 2 years ago

Let's also bump the version before merging to make a new release?

dcastro commented 2 years ago

Let's also bump the version before merging to make a new release?

Done. Also added @since haddock metadata, which I think we should start using going forward, what do you think?

gromakovsky commented 2 years ago

Done. Also added @since haddock metadata, which I think we should start using going forward, what do you think?

Yes, sounds good, just a bit hard to keep in mind when you don't develop libraries on a regular basis :slightly_smiling_face: