Closed dcastro closed 2 years ago
Let's also bump the version before merging to make a new release?
Let's also bump the version before merging to make a new release?
Done. Also added @since
haddock metadata, which I think we should start using going forward, what do you think?
Done. Also added
@since
haddock metadata, which I think we should start using going forward, what do you think?
Yes, sounds good, just a bit hard to keep in mind when you don't develop libraries on a regular basis :slightly_smiling_face:
Description
Problem: In order to be compliant with the stackage nightly, the test suite needs to buildable with tasty-hedgehog 1.2.0.0. At the moment, we have a constraint on
tasty-hedgehog < 1.2.0.0
because that version deprecates thetestProperty
function (and encourages usingtestPropertyNamed
instead), which we're still using.Solution: we don't actually need to use either
testProperty
ortestPropertyNamed
, we can just usetasty-discover
to collect all tests.Related issues(s)
Fixed #270
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).
Related changes (conditional)
Tests
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.