Problem:
As in #277, some of our HLint rules have parenthesized lhs, e.g.
- warn: {lhs: (maybe pass f m), rhs: Universum.whenJust m f}
Such rules are triggering only on parnthisized code, e.g. rule above is not triggering on x = maybe pass f m.
Of course, we want to suggest whenJust in this case.
Solution:
Remove extra parenthesis in such rules, test this solves issue and is not leading to false reports.
Tested using HLint 3.5 (lastest) and 3.3.6
Related issues(s)
Fixed #279
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
[x] I made sure my PR addresses a single concern, or multiple concerns which
are inextricably linked. Otherwise I should open multiple PR's.
[x] If I added/removed/deprecated functions/re-exports,
I checked whether these changes impact the .hlint.yaml rules
and updated them if needed.
Related changes (conditional)
Tests
[x] If I added new functionality, I added tests covering it.
[x] If I fixed a bug, I added a regression test to prevent the bug from
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
[x] I added an entry to the changelog if my changes are visible to the users
and
[x] provided a migration guide for breaking changes if possible
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:[#42] Short commit description
If necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
Description
Problem: As in #277, some of our HLint rules have parenthesized lhs, e.g.
Such rules are triggering only on parnthisized code, e.g. rule above is not triggering on
x = maybe pass f m. Of course, we want to suggestwhenJustin this case.Solution: Remove extra parenthesis in such rules, test this solves issue and is not leading to false reports. Tested using HLint 3.5 (lastest) and 3.3.6
Related issues(s)
Fixed #279
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).
.hlint.yamlrules and updated them if needed.Related changes (conditional)
Tests
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Stylistic guide (mandatory)
[x] My commit history is clean (only contains changes relating to my issue/pull request and no reverted-my-earlier-commit changes) and commit messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been made/pushed using rebase and squash.