serokell / xrefcheck

Check cross-references in repository documents
Mozilla Public License 2.0
51 stars 3 forks source link

[#235] Refactor progress bar interface #265

Closed aeqz closed 1 year ago

aeqz commented 1 year ago

Description

Problem: the current progress bar interface is quite low-level and error-prone.

Solution: the proposed solution here modifies both the progress bar internal model and interface by representing progress units by witnesses. It does not require great changes, but the resulting interface is clearer and less error-prone.

Related issue(s)

Relates #235

:white_check_mark: Checklist for your Pull Request

Related changes

Stylistic guide

YuriRomanowski commented 1 year ago

I like how you changed the Progress fields and I like your trick with Set :) I think this is cool, approved.