search

serokell / xrefcheck

Check cross-references in repository documents
Mozilla Public License 2.0
54 stars 3 forks source link

[BUG] Failure with NoResponseDataReceived #280

Closed Martoon-00 closed 1 year ago

Martoon-00 commented 1 year ago

Description

In ligo repository xrefcheck currently fails for one link:

  ➥  In file vendored-dune/Preprocessor/README.md
     bad reference (external) at src:517:1-107:
       - text: "minimal module system"
       - link: https://ligolang.org/docs/language-basics/modules
       - anchor: modules-and-imports-build-system

     ⛂  NoResponseDataReceived

and I see no reasons for that link to be considered invalid.

To Reproduce

  1. Create a document with https://ligolang.org/docs/language-basics/modules link.
  2. Run xrefcheck

Expected behavior

The check passes.

Environment

dcastro commented 1 year ago

Why is NoResponseDataReceived only happening for that particular link though?

The docs say this:

No response data was received from the server at all. This exception may deserve special handling within the library, since it may indicate that a pipelining has been used, and a connection thought to be open was in fact closed.

So it looks like a connection issue (which would imply that xrefcheck was unable to check whether the link is valid or not, so it's inconclusive).

Martoon-00 commented 1 year ago

Oh, really. Thanks for the quick look at this.

I retried that job, and the issue turned out to be transitive. So the current behaviour seems good as it is.