serokell / xrefcheck

Check cross-references in repository documents
Mozilla Public License 2.0
51 stars 3 forks source link

[Chore] Use LTS-21 #290

Open gromakovsky opened 11 months ago

gromakovsky commented 11 months ago

Description

This PR updated the Stackage resolver to the latest one and does some related cleaning.

Related issue(s)

Resolves #285

:white_check_mark: Checklist for your Pull Request

Ideally a PR has all of the checkmarks set.

If something in this list is irrelevant to your PR, you should still set this checkmark indicating that you are sure it is dealt with (be that by irrelevance).

Related changes (conditional)

Stylistic guide (mandatory)

✓ Release Checklist

serokell-bot commented 11 months ago
3 Warnings
:warning: In d012849441590c9c5890ec45e272f02f97076062 message lacks issue id: Automatically update flake.lock to the latest version.
See also [Note].
:warning: Description of d012849441590c9c5890ec45e272f02f97076062 does not follow the template.
Try Problem:/Solution: structure.
If you really have to, you can add And yes, I don't care about templates to the commit message body.
See also [Note].
:warning: Bad issue ID in branch name.
Valid format for issue IDs: #123 or chore.

[Note]: Skip this check by adding wip, tmp or [temporary] to the commit subject. Fixup commits (marked with fixup! or squash!) are also exempt from this check.

Generated by :no_entry_sign: Danger

Martoon-00 commented 7 months ago

CI is failing due to warnings / compilation errors also related to LTS-21. Other than that, LGTM.

gromakovsky commented 7 months ago

@Martoon-00 if you volunteer to fix them by any chance, feel free to go ahead :wink:

Martoon-00 commented 7 months ago

Okay, I fixed the errors that I saw (note there are fixup commits, you may want to squash them after reviewing them).

However now some really scary errors bumped up, and I have to switch to other activities, so giving up on this right now.

gromakovsky commented 5 months ago

note there are fixup commits, you may want to squash them after reviewing them

Reviewed, squashed.

Also updated the resolver to a bit newer one, so that a newer minor GHC version is used. Let's see if it helps with any of scary errors. UPD: there are still some weird errors, not sure if it helped with any of them, but definitely not with all of them.

serokell-bot commented 2 weeks ago
1 Error
:no_entry_sign: Some fixup commits are still there.

Generated by :no_entry_sign: Danger