Review urls structure - Githubissues

serp-spider / core

:spider: The PHP SERP Spider - A search engine scraper

https://serp-spider.github.io/

Other

89 stars 44 forks source link

Review urls structure #1

Closed gsouf closed 8 years ago

gsouf commented 8 years ago

Think about a common interface instead of UrlArchive
Review the relations between url/and urls that can generate requests (consider moving GoogleUrl::generateRequest away)
Review the url factory (currently the constructor is used, that's not flexible)
SerpUrlInterface should extend some UrlInterface

gsouf commented 8 years ago

The constructor was frozen for the factory. It's good because it allows url to remain a standard thing. If we need different way to construct url for search engines the best will be some special factories. For instance: Google::Url(...);