search

serp-spider / core

:spider: The PHP SERP Spider - A search engine scraper
https://serp-spider.github.io/
Other
89 stars 44 forks source link

Proxy Type #11

Closed hughsaffar closed 8 years ago

hughsaffar commented 8 years ago

Integrated Proxy Type (SOCKS4 and SOCKS5)

gsouf commented 8 years ago

I'm wondering if it's better or not to replace the scheme instead of using both of scheme and type.

RubtsovAV commented 8 years ago

I think too. It's not good. Because it will break backwards compatibility. I think it would be better to add a method setType() instead of changing the constructor.

gsouf commented 8 years ago

Changing the constructor is not a problem, the library is still in alpha, there is no backward compatibility awareness for the moment , it's rather that the scheme is irelevent in case of sock proxy

RubtsovAV commented 8 years ago

It will be more better than new method.

gsouf commented 8 years ago

I merge and I will bring further changes