serp-spider / search-engine-google

:spider: Google client for SERPS
https://serp-spider.github.io
Other
168 stars 61 forks source link

Fix parsing of latest version of classic Google search #111

Closed msiemens closed 6 years ago

msiemens commented 6 years ago

This fixes parsing the latest version of classic Google search results.

Closes #105 Closes #110

msiemens commented 6 years ago

Still got a test error, I'm currently looking into it

msiemens commented 6 years ago

Fixed, all tests pass now!

dennisoderwald commented 6 years ago

@gsouf Can you please merge that?

gsouf commented 6 years ago

Hi @msiemens

Thanks for your contribution, that's appreciated.

I added 2 comments that are quick fixes you can make to the PR. Can you look at them please?

msiemens commented 6 years ago

Thanks! I've changed the code as requested 🙃

msiemens commented 6 years ago

Thanks for the fast merge, @gsouf ❤️

gsouf commented 6 years ago

You're welcome, thanks to you for the good PR with updated unit tests.

That's published with version v0.4.3