search

serp-spider / search-engine-google

:spider: Google client for SERPS
https://serp-spider.github.io
Other
168 stars 61 forks source link

Add parsing of WikiBox #39

Open Shiftas opened 8 years ago

Shiftas commented 8 years ago

Implementation of wiki box parser. Only for works for evaluated pages.

Feel free to decline it if you feel it is too incomplete to be added, as not all fields from wiki box is parsed and I do not have tests for this.

gsouf commented 8 years ago

Hi, I'll review this asap

gsouf commented 8 years ago

Thanks for the contribution it's very appreciated.

I need to think about it, because I'm not sure if wiki parser support is very helpful for the moment because it will add a lot of maintenance for a side part of the library. The main goal is to parse natural result, and as a second goal adwords result, I still need some work to make that stable.

Well, we could offer it as a plugin, or leave it in development stage in its own branch until I feel it's ok to merge it. I need to think for the best solution. In any cases I have a lot of improvement and a few refactoring to bring before.

What is your use case of the wikiboxes?

Shiftas commented 8 years ago

Well, i need to get info out of it, like title, description, map details etc. I later use them for some data processing. And as I said, its just a suggestion, so if you feel it does not belong here, just reject it. I have already implemented it outside of this library, as it is quite easy to extend without actually changing it.

thebennos commented 7 years ago

detecting of wikiboxes would be nice. +1 for this pull request.