search

serpapi / google-search-results-java

Google Search Results JAVA API via SerpApi
https://serpapi.com
MIT License
33 stars 24 forks source link

fixed the Makefile in demo && fixed the readme #1

Closed albertcoder closed 3 years ago

albertcoder commented 3 years ago

Hi maintainers,

There was a bug in the Makefile under demo directory. I was able to fix it and also updated the commands in the readme file for quick installation. Following were the errors I was getting before the fix. It was failing at make run command. Since there was only one file to be copied, it was copying it as a file called "lib" rather than copying a file under the newly created "lib" directory. The quick installation commands are also updated in the Makefile under demo directory so you should be able to execute it properly.

Screenshot from 2020-09-18 16-14-51

Screenshot from 2020-09-18 16-16-36

It runs successfully post fix as in the following screenshot.

Screenshot from 2020-09-18 16-17-56

Please review and accept my pull request.

Thank you.

jvmvik commented 3 years ago

Thanks you very much for your feedback. And sorry for the delay and replying I upgraded to gradle 6.7.1 and clean-up the warnings. I integrated your inputs in the latest release.