Gem forces the use of `q` parameter for engines that is not used

[hartator]

We have several engines that work without a q parameter.

For example, Yande uses text:

And you can't submit your search to the API.

Hash with all engines that don't use q parameter:

{
  ebay: '_nkw',
  google_maps_reviews: 'data_id',
  google_product: 'product_id',
  google_scholar_author: 'author_id',
  google_scholar_profiles: 'mauthors',
  home_depot_product: 'product_id',
  walmart: 'query',
  walmart_product: 'product_id',
  yahoo: 'p',
  yandex: 'text',
  youtube: 'search_query',
  naver: 'query',
  apple_app_store: 'term',
  apple_reviews: 'product_id',
  yahoo_shopping: 'p',
  google_play_product: 'product_id',
}

We can explicitly check on this but I think it will easier to just drop the requirement of a q parameter for all engines.

[DEADF00D]

Happened again

Request: {
  :engine=>"yahoo", 
  :p=>"serpapi", 
  :api_key=>"<censored>"
}

/home/<censored>/.gem/ruby/3.0.0/gems/google_search_results-2.2.0/lib/search/serp_api_search.rb:178:in `check_params': missing required keys in params:  (SerpApiException)
 - q
        from /home/<censored>/.gem/ruby/3.0.0/gems/google_search_results-2.2.0/lib/search/google_search.rb:36:in `initialize'
        from se_everywhere.rb:41:in `new'
        from se_everywhere.rb:41:in `block in <main>'
        from se_everywhere.rb:32:in `each'
        from se_everywhere.rb:32:in `<main>'

[DEADF00D]

Actually, The library the right, and playground is false. Yahoo requirements are already defined under the YahooSearch class:

class YahooSearch < SerpApiSearch
  def initialize(params = {})
    super(params, YAHOO_ENGINE)
    check_params([:p, :engine])
  end
  ...
end

By replacing the GoogleSearch class by YahooSearch. It's now working.

We should fix code generation from API Playground to change class depending of the engine used.

[paigebutler]

I'm still facing the same issue with yahoo

[jvmvik]

This is resolved by https://github.com/serpapi/serpapi-ruby The gem should be published soon.