search

serpapi / google-search-results-ruby

Google Search Results via SERP API Ruby Gem
https://serpapi.com
MIT License
52 stars 8 forks source link

Add support for all API supported by Serp API #4

Closed jvmvik closed 5 years ago

jvmvik commented 5 years ago

Update documentation to be more usefull Update to rspec tests

hartator commented 5 years ago

Awesome work on the documentation and the added API endpoints.

I wonder why 1.9.2 SSL wasn't working anymore. Maybe it's an issue on the Ruby side or with the Cloudflare SSL. The actual error on Travis CI for future reference: OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=unknown state: sslv3 alert handshake failure

May be relevant: https://stackoverflow.com/questions/17369962/opensslsslsslerror-ssl-connect-returned-1-errno-0-state-unknown-state-unkn

hartator commented 5 years ago

I've temporally disabled TLS 1.3 on Cloudflare side.

It was causing issues on other parts of SerpApi anyway. It should fix sslv3 alert handshake failure error.

Support for TLS 1.3 has only being rolled out since summer 2018. We'll try again in a year.