Dev fixes - Githubissues

serpapi / serpapi-python

an official Python client library for SerpApi.

https://pypi.org/project/serpapi/

MIT License

46 stars 4 forks source link

Dev fixes #2

Closed ilyazub closed 1 year ago

ilyazub commented 1 year ago

We with @dimitryzub reviewed #1 and applied some fixes:

Paste documentation examples to README.md in a loop instead of duplicating the same lines for all of the engines.
Changed signature of the serpapi.Client to accept three parameters instead of a dict. This mentally distinguishes arguments allowed to the client from the Client#search() method.
Fixed make all execution by prepending python -m to Python commands.

This PR is WIP. We will copy examples from https://github.com/serpapi/google-search-results-python/pull/36 to this PR.

jvmvik commented 1 year ago

I integrate 2/3 changes in the master.

Approved

Paste documentation examples to README.md in a loop instead of duplicating the same lines for all of the engines.
Fixed make all execution by prepending python -m to Python commands.

Rejected

Changed signature of the serpapi.Client to accept three parameters instead of a dict. This mentally distinguishes arguments allowed to the client from the Client#search() method. We had a thread on this with Julien ~3 weeks ago.