search

serpapi / turbo_tests

Run RSpec tests on multiple cores. Like parallel_tests but with incremental summarized output. Originally extracted from the Discourse and Rubygems source code.
https://rubygems.org/gems/turbo_tests
MIT License
173 stars 26 forks source link

Is bundler a dependency of turbo tests? #42

Closed deivid-rodriguez closed 1 year ago

deivid-rodriguez commented 1 year ago

I'm trying to add turbo tests to dependabot-core at https://github.com/dependabot/dependabot-core/pull/8092, but I'm getting an issue due to the dependency on Bundler.

So this is a question-PR. Does turbo tests actually depend on Bundler?

deivid-rodriguez commented 1 year ago

Oh, I see, I totally missed that. Thanks!

I believe if we are already in a bundle exec context, we already have the proper ENV setup, so just rspec would use the rspec version in your app context. While if you're not in a bundle exec context, rspec should look for a globally installed rspec version.

So maybe rspec without bundle exec just works.

deivid-rodriguez commented 1 year ago

Thanks, I just noticed that the hard dependency on bundler was removed by d0d84ac80429a34b5c803a15311315dbda17bb5b, so I think it's indeed fine to remove the dependency since it's now optional.

ilyazub commented 1 year ago

I just released this PR in turbo_tests v2.2.0

@deivid-rodriguez Thank you for introducing turbo_tests to dependabot! Let's see if helps to fix the ci-test in https://github.com/dependabot/dependabot-core/pull/8092.

deivid-rodriguez commented 1 year ago

Thank you!