Handle fuubar - Githubissues

serpapi / turbo_tests

Run RSpec tests on multiple cores. Like parallel_tests but with incremental summarized output. Originally extracted from the Discourse and Rubygems source code.

https://rubygems.org/gems/turbo_tests

MIT License

173 stars 25 forks source link

Handle fuubar #51

Open inkstak opened 4 months ago

inkstak commented 4 months ago

Fix #23 : Allow to use the Fuubar formatter.

This pull request depends on #41. The changes from #41 could be seen https://github.com/inkstak/turbo_tests/compare/feature-parallel_options...feature-handle_fuubar

inkstak commented 4 months ago

I had issues when using JSON formatter for extracting the number of total examples as suggested in https://github.com/serpapi/turbo_tests/issues/23#issuecomment-1398360273 The backticks capture the full output of the command, which may include other puts.

For example:

We have Dotenv configured to output which files are loaded on top of every rspec command: [dotenv] Load .env.test
Simplecov might output a line after the JSON output : Coverage report generated for ... (x%) covered.

Any ideas ?

inkstak commented 4 months ago

PR updated :

I finally succeed to properly calculate the examples count using the JSON formatter as suggested in https://github.com/serpapi/turbo_tests/issues/23#issuecomment-1398360273 by using a temporary file.
I removed all references specifici to Fuubar: the changes could now benefit to any custom formatter that requires the examples_count.

Changes are splitted in two commits :

e1f8f6b3dab7ceeabad7b26de84e473b91bb88d5 is only a refactoring of the Runner class to allow forwarding files & parallel options (which depends on #41) to the Reporter
6bfb97ba91b3d92f27595bae075dd11010e38246 add a start notification with the examples_count

inkstak commented 4 months ago

One more thing : to use Fuubar, you need to require it in the command :

bundle exec turbo_tests -r fuubar -f Fuubar spec/whatever