serpent-os / boulder-d-legacy

Replaced by Rust tooling
https://serpentos.com
21 stars 7 forks source link

Git sources require networking: yes #55

Closed ReillyBrogan closed 1 year ago

ReillyBrogan commented 1 year ago

Tried the git support with glibc and got the following error message:

+ git -C glibc init
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint:   git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint:   git branch -m <name>
Initialized empty Git repository in /mason/build/build/emul32/x86_64/glibc/.git/
+ git -C glibc remote add origin https://sourceware.org/git/glibc.git
+ git -C glibc fetch --depth 1 origin d8e1a7590d375159fb5aac07ad8111ab4699e994
fatal: unable to access 'https://sourceware.org/git/glibc.git/': Could not resolve host: sourceware.org
+ echo Failed to fetch git repo
Failed to fetch git repo

This went away when I added networking: yes. The git steps should probably be ran on the host instead of from within the build environment to prevent unnecessary network access, or having a git source URI should imply networking: yes.

GZGavinZhao commented 1 year ago

Huh, I thought I made the fetching step to run on the host, and if I didn't, I should've gotten the same error when I was testing. I'll have to check that. Are you using glibc recipe file in snekpit/toolchain#5?

ReillyBrogan commented 1 year ago

Huh, I thought I made the fetching step to run on the host, and if I didn't, I should've gotten the same error when I was testing. I'll have to check that. Are you using glibc recipe file in snekpit/toolchain#5?

Yes.

GZGavinZhao commented 1 year ago

The commands look like those at here which I clearly deleted in the Git PR. Though the question may seem dumb, are you using the latest version?

ReillyBrogan commented 1 year ago

OK, I tested again just now and I think the issue was that boulder in the repos was outdated (updated by Ikey in commit. This is resolved now.