search

serratus-bio / serratus.io

Front-end code for Serratus project website
https://serratus.io
GNU Affero General Public License v3.0
11 stars 11 forks source link

Bumped the number of PalmID requests #199

Closed hannahle closed 1 year ago

hannahle commented 1 year ago

Summary of changes

The number of requests before a timeout is bumped from 60 to 120.

Checklist

Manual testing

Here's an example of a sequence that used to fail on a 60-request timeout limit: 

>betaflax_sativa
SNQFNDMKTLRGKNWNNYVYVFETIYPRHQSSDDLTFFAAIQKRLLRSNP
EKEARKLEKSWGIGSIMFHELKRTLGLNPNVYIDEEVVNREFVQKRLNKS
AKLIENHSGRSDPDWRLDHFFLFMKSQLCTKFEKRFVDAKAGQTLACFSH
QILTRFGVAFRTFEKKFSANLPKTWYVHTMKNFDQLNLWACENVKEREGT
ESDYEAFDRSQDAPILAFEILMLRFFNWPEDLIQDYKMIKLWMGCRLGAV
AIMRFTGEFGTFFFNTLVNMAFTVMRYHVNKESVIAFAGDDMYAAGFLKR
RVDLEFALDQLTLKAKVQFTRRPMFCGWYMTPMGIVKEPRLVLERWKIAE
QKGNLRDVIINYALEVSYGYRLGEYLWEVLDNLESQQEIVRNIVKSKHLL
PLKVRHFFSAVDNETLSTEF

After increasing the request limit, an error report was returned as expected here: https://s3.amazonaws.com/openvirome.com/betaflax_sativa.html

In addition to the change made here, the timeout for the PalmID Lambda API function was also bumped from 5 minutes to 10 minutes.

victorlin commented 1 year ago

Preview app for this PR's source branch: https://hannah-timeout-bump.d1w6d75be7tofa.amplifyapp.com/

ababaian commented 1 year ago

@hannahhanle I think this will solve any time-out issue, as of right now AWS-Lambda has a hard-coded timeout after 5 minutes. The page refreshes 60 times (every 5 seconds) and after 5 minutes if an output is not generated it is assumed that the lambda-function has self-terminated. If you're increasing refreshes to 10 minutes, the lambda timeout has to be adjusted as well.

hannahhanle commented 1 year ago

@hannahhanle I think this will solve any time-out issue, as of right now AWS-Lambda has a hard-coded timeout after 5 minutes. The page refreshes 60 times (every 5 seconds) and after 5 minutes if an output is not generated it is assumed that the lambda-function has self-terminated. If you're increasing refreshes to 10 minutes, the lambda timeout has to be adjusted as well.

Yes, this is what I did. I already adjusted the lambda timeout as well!