Explore chart: match look of figure in paper

serratus-bio / serratus.io

Front-end code for Serratus project website

https://serratus.io

GNU Affero General Public License v3.0

11 stars 11 forks source link

Closed victorlin closed 4 years ago

victorlin commented 4 years ago

This pull request will close #62 and close #63.

Summary of changes

Convert Explore chart to histogram
- Note: performance is noticeably slower than the current area chart. D3 has to render several rectangles per color rather than one continuous shape.
Use viridis color scale for score/coverage value domain

TODO

[x] first 15 score (z) values aren't being rendered. need to fix this
[x] fix y-axis scaling delays when changing between families
[x] fix rendering of empty data (ex. switching from default Coronaviridae -> Adomaviridae). currently it doesn't update at all
~optimize rendering where possible~

ababaian commented 4 years ago

:D :D :D Tight!

Values below score 25 are not rendering. If you change CoV to score 0 - 100 the Y-axis scales correclty but no extra bars are visible.

Also is it possible to remove the white-outline on the bars so it's just continuous gradient all the way through.

victorlin commented 4 years ago

Values below score 25 are not rendering

This is some weird bug - actually it is values [0,15] that aren't showing for me. Can you double check?

Also is it possible to remove the white-outline on the bars so it's just continuous gradient all the way through.

Also a weird bug. Added a small border to all the bars so that white outline shouldn't show anymore.

ababaian commented 4 years ago

Still seeing the borders and you're right it's1q 15

victorlin commented 4 years ago

@ababaian everything should be fixed now, plus a change in color palette :)

My only concern is the rendering lag when adjusting sliders. It's pretty noticeable on my machine, what do you think?

edit: it's actually OK on chromium-based browsers - Safari is just a turtle.

victorlin commented 4 years ago

My only suggestion is to move the selector and "Go" button to the center

@lohrd thanks, will add those edits to a a larger change for the unified Explorer page!

ababaian commented 4 years ago

Make sure to update the re-direct from serratus.io/family to serratus.io/explore when that PR goes down