search

sersorrel / WhosTalking

See Discord voice activity indicators directly on your party list.
3 stars 5 forks source link

Exception spam in DRS #15

Closed sersorrel closed 5 months ago

sersorrel commented 5 months ago

https://discord.com/channels/581875019861328007/653504487352303619/1241851347947491328

Crashes here:

https://github.com/sersorrel/WhosTalking/blob/155bfb47cee996b1f43f189fa3c7bc5fb38e2014/WhosTalking/Plugin.cs#L326-L329

Presumably GroupManager.Instance() returns null?

I should also null-check the return value of that call itself.

Also, this check is broken:

https://github.com/sersorrel/WhosTalking/blob/155bfb47cee996b1f43f189fa3c7bc5fb38e2014/WhosTalking/Plugin.cs#L294-L302

I suspect I need to check VisibilityFlags, like I already do for the party list.

sersorrel commented 5 months ago

Should be fixed in 0.6.10.0.