Open sersorrel opened 1 week ago
we should check for null pointers basically everywhere we use pointers. but we don't. for example, here:
https://github.com/sersorrel/WhosTalking/blob/c57f8c039d83a14e06b603a7c305f8f98181feaa/WhosTalking/Plugin.cs#L293
I suspect the stack trace at https://discord.com/channels/581875019861328007/892131028188151808/1282834623700930591 is due to PartyMemberComponent being null on that line. (the line numbers in the stack trace are weird so I can't be sure.)
PartyMemberComponent
regardless, we should improve both this line and all the other pointer derefs.
we should check for null pointers basically everywhere we use pointers. but we don't. for example, here:
https://github.com/sersorrel/WhosTalking/blob/c57f8c039d83a14e06b603a7c305f8f98181feaa/WhosTalking/Plugin.cs#L293
I suspect the stack trace at https://discord.com/channels/581875019861328007/892131028188151808/1282834623700930591 is due to
PartyMemberComponentbeing null on that line. (the line numbers in the stack trace are weird so I can't be sure.)regardless, we should improve both this line and all the other pointer derefs.