sertain / sertain-legacy

:robot: Write more for your robot with less
https://sertain.github.io/javadocs
MIT License
9 stars 3 forks source link

Don't deploy docs if only changes are generation time changes #32

Closed andrewda closed 6 years ago

andrewda commented 6 years ago

Commits like https://github.com/sertain/javadocs/commit/d12c12bf2d44bde14e19d5cda32a9a4e4fb9936f are totally useless and just clutter up the commit history (even if it is all automated, it'd still be nice to only push to the documentation repo when the documentation actually needs to be changed).

Maybe check if there's the same number of files changes, additions and deletions, i.e. 1 addition and deletion per file? Or maybe there's a way to not create the generation timestamps in Dokka?

SUPERCILEX commented 6 years ago

Oh lol, yeah, that's pretty sad. In the Firebase world, docs are only deployed on tag builds. I'll let you do the shell magic...

On Fri, Jan 19, 2018 at 9:35 AM Andrew Dassonville notifications@github.com wrote:

Commits like sertain/javadocs@d12c12b https://github.com/sertain/javadocs/commit/d12c12bf2d44bde14e19d5cda32a9a4e4fb9936f are totally useless and just clutter up the commit history (even if it is all automated, it'd still be nice to only push to the documentation repo when the documentation actually needs to be changed).

Maybe check if there's the same number of files changes, additions and deletions, i.e. 1 addition and deletion per file? Or maybe there's a way to not create the generation timestamps in Dokka?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sertain/sertain/issues/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AJDRJMmpyr_ZkEViR61030bk1cOFlDGJks5tMNJKgaJpZM4Rkzyk .

andrewda commented 6 years ago

That's a good idea.